Fix for functions called "new"

tempestphp · Aug 27, 2024 · ca84b97 · ca84b97
1 parent 0679847
commit ca84b97
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/UPGRADING.md b/UPGRADING.md
@@ -6,6 +6,7 @@
 - Fix for attribute in promoted property (#133)
 - Fix for comments in function argument lists (#134)
 - Fix for variadic types (#140)
+- Fix for functions called "new" (#141)
 
 ## 2.8.2
 

diff --git a/src/Languages/Php/PhpLanguage.php b/src/Languages/Php/PhpLanguage.php
@@ -84,6 +84,7 @@ public function getPatterns(): array
             new OperatorPattern('\|\|'),
             new OperatorPattern('<=>'),
             new OperatorPattern('\?'),
+            new FunctionNamePattern(),
 
             // KEYWORDS
             new KeywordPattern('null'),
@@ -190,7 +191,6 @@ public function getPatterns(): array
             // PROPERTIES
             new ClassPropertyPattern(),
             new PropertyAccessPattern(),
-            new FunctionNamePattern(),
             new NestedFunctionCallPattern(),
             new FunctionCallPattern(),
             new ConstantPropertyPattern(),

diff --git a/tests/Languages/Php/PhpLanguageTest.php b/tests/Languages/Php/PhpLanguageTest.php
@@ -135,6 +135,7 @@ public function info(
          * hello */</span>
         <span class="hl-keyword">public</span> <span class="hl-type">?array</span> <span class="hl-property">$chapters</span>,
     </span>) {}'],
+            ['public static function new(mixed ...$params): self;', '<span class="hl-keyword">public</span> <span class="hl-keyword">static</span> <span class="hl-keyword">function</span> <span class="hl-property">new</span>(<span class="hl-injection"><span class="hl-type">mixed</span> ...$params</span>): <span class="hl-type">self</span>;'],
         ];
     }
 }
diff --git a/tests/targets/test.md b/tests/targets/test.md
@@ -1,3 +1,3 @@
 ```php
-public function update(Foo ...$params): self;
-``` 
+public static function new(mixed ...$params): self;
+```