Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions and Possible Bugs #137

Closed
lemmon opened this issue Aug 4, 2024 · 5 comments
Closed

Questions and Possible Bugs #137

lemmon opened this issue Aug 4, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@lemmon
Copy link
Contributor

lemmon commented Aug 4, 2024

I noticed some strange behaviour. Not sure whether it's documented somewhere or not so I'm summarizing it here with few examples.

Screenshot 2024-08-04 at 11-16-03

  1. Is there any particular reason why strings are being highlighted without the quotation marks? (both Javascript and PHP)
  2. Why numbers are not being highlighted. (PHP)
  3. Numbers are not being highlighted and the decimal part is being treated as a property. (Javascript)
@brendt brendt added the bug Something isn't working label Aug 27, 2024
@brendt
Copy link
Member

brendt commented Aug 27, 2024

I'll look into these and fix them :)

@lemmon
Copy link
Contributor Author

lemmon commented Sep 3, 2024

Need help? I can look into it. But I was wondering if those strings without quot marks are intentional.

@brendt
Copy link
Member

brendt commented Sep 4, 2024

You're welcome to send a PR, sure :) I believe the quoted strings are intentional, but I'm fine changing them to include the quotes — makes more sense to me.

@lemmon
Copy link
Contributor Author

lemmon commented Sep 5, 2024

Allright. I'll try to do both PHP and JavaScript. See how that goes. Also, attaching another issue with strings:

Screenshot 2024-09-05 at 09-36-30 Test

lemmon added a commit to lemmon/tempestphp-highlight that referenced this issue Sep 6, 2024
@brendt
Copy link
Member

brendt commented Oct 24, 2024

This is merged now :)

@brendt brendt closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants