Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Commonmark HighlightExtension #102

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Apr 16, 2024

Twig/Symfony currently only allows registering extensions (not renderers) in the service container. But in general, I think packaging these two renderers into a single extension is useful.

@kbond kbond force-pushed the commonmark-extension branch from 02c3e0f to 3d43ce7 Compare April 16, 2024 21:37
@brendt
Copy link
Member

brendt commented Apr 25, 2024

Thanks! I've moved the README contents to https://tempest.stitcher.io/highlight/01-getting-started, so I'll add your section there as well!

@brendt brendt merged commit 14a3397 into tempestphp:main Apr 25, 2024
4 checks passed
@coveralls
Copy link

coveralls commented Apr 25, 2024

Pull Request Test Coverage Report for Build 8831279193

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 94.059%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/CommonMark/HighlightExtension.php 0 5 0.0%
Totals Coverage Status
Change from base Build 8831264520: -0.3%
Covered Lines: 1425
Relevant Lines: 1515

💛 - Coveralls

@brendt
Copy link
Member

brendt commented Apr 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants