feat: Argument Bag, aliases, help lines #1
Conversation
przemyslaw-przylucki
changed the title
src/ConsoleInputBuilder.php
Outdated
| */ | ||
| unset($passedArguments[$idx]); | ||
| unset($definitionArguments[$definitionIdx]); | ||
| continue 2; |
There was a problem hiding this comment.
I'd prefer to not having to rely on continue 2. Maybe it's an indication that this nested loop should be refactored to a separate (private) function for simplicity?
There was a problem hiding this comment.
Fixed - had to use reference which I don't love - if you have better idea lemme know
There was a problem hiding this comment.
Couldn't we determine whether we should unset the array key based on the output of resolveArgument?
If it's null, we won't unset?
|
@brendt lemme know what you think! Also lemme know if contributions this early are helpful for you - I love this project and would love to help as much as possible, but I don't want to come off as intrusive. So if it's counterproductive atm because of the stage lemme know - do not want to disrupt your vision. Otherwise - excited to add a bunch of goodies after this gets merged 🙇 |
| ) { | ||
| } | ||
|
|
||
| public static function fromString(string $argument, int $position): ConsoleInputArgument |
There was a problem hiding this comment.
I'm wondering: do we need to keep track of the position? I'd assume the position is implied because we're looping over all input in order?
|
Both my comments aren't blockers btw, just curious about your input.
They absolutely are helpful, no worries! As long as you're willing to put up with me sometimes requiring a couple of days before being able to review code, and my reviews in general, we're totally fine :) |
#1 hell yeah
Adds additional functionality to the console app by creating a ConsoleArgumentBag.
The bag is a class responsible for:
a) holding all of the arguments passed to function
b) creating ConsoleInput, which is a prepared list of available arguments with values. This can throw if the count of arguments doesn't match handler's method signature
It also adds support for:
I've decided to go with help as an array, I think that for more advanced CLI apps, this could be benefitial.
I think we should have description and help as two separate entities.
Help would be responsible for providing information on how different values of an argument can affect execution, whereas description just expands on the name or illustrates the use-case.