feat(console): add make:view command
#864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innocenzi
previously requested changes
Dec 20, 2024
Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
make:viewcommandThis PR check a TODO on #759
I'm not familiar with the view system in Tempest so I need detailed review on stubs and supported generated classes.
That being said, I currently support the creation of a basic view file like this :
make:view home=> this will ask forhome.view.phppath and then creates an empty php filemake:view HomeView class=> this second enum parameter will specify that we want to create the view class documented here https://tempestphp.com/docs/framework/views/#view-objectsI don't know if more view class are needed for this command, but I think this is something that can be added when needed 😄