Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuilder #889

Closed
Tomisslaw opened this issue Nov 27, 2024 · 8 comments · Fixed by #886
Closed

FormBuilder #889

Tomisslaw opened this issue Nov 27, 2024 · 8 comments · Fixed by #886
Labels
bug Something isn't working
Milestone

Comments

@Tomisslaw
Copy link

I started with the Astroid QuickStart Package with the Astroid Core 3.1.7. There was a "Undefined" bug with the FormBuilder, I fixed it like described here Commit 0a0433a. In the meantime I updated to Astroid 3.1.8. and continued to work on the form. I made a form similar to this in the Article Layout builder. https://demo.astroidframe.work/article-layouts/tours-example/danube-by-bike-and-boat

And here is the problem. When I change the Form parameters (just some values in the in the Article "form builder widget", it do not apply this widget (i changed some fields), instead, it pick up the values from the form in the Article Layout Builder.

Let say i made in the Article Layout builder this
image

And i changed it in the "Article widget" in to this

image

When I submit the form, i still get an email with the "Subject A".

Curent setup

Joomla 5.2.2
Astroid 3.1.8
php 8.3

Am I doing something wrong, or is this a bug?

@felixkat
Copy link

felixkat commented Nov 28, 2024

Yes, I can confirm this issue.

I created a similar form via the Article Layout Builder and sent a couple of test emails. I then changed the email body content via the article widget and the output is still the original.

Article Builder

image

Widget

image

Email received after changes to the widget.

From:First Name Last Name AAA
Email:xxx@xxx.com AAA
Subject:This is Subject AAA
Message:Test Message AAAA
Sender IP: xx.xx.xx.xx

@sonvnn
Copy link
Member

sonvnn commented Nov 29, 2024

@Tomisslaw @felixkat Thank you for report the issue. I fixed this at b1f0395

Please help me download v3-branch and retest it.

Best Regards,
Sonny

@sonvnn sonvnn added the bug Something isn't working label Nov 29, 2024
@sonvnn sonvnn added this to the Version 3.1.9 milestone Nov 29, 2024
@sonvnn sonvnn linked a pull request Nov 29, 2024 that will close this issue
@sonvnn sonvnn moved this to In review in Astroid Framework Nov 29, 2024
@felixkat
Copy link

@Tomisslaw @felixkat Thank you for report the issue. I fixed this at b1f0395

Please help me download v3-branch and retest it.

Best Regards, Sonny

Tested and working on my site. Will wait for @Tomisslaw to confirm.

@Tomisslaw
Copy link
Author

I will test it tomorrow and let you know.
Thanks.

@Tomisslaw
Copy link
Author

Tomisslaw commented Nov 30, 2024

I confirm that the bug is fixed.
My knowledge is very limited, but maybe I can help in some way, let me know. I could translate the framework maybe.
Thanks.

@github-project-automation github-project-automation bot moved this from In review to Done in Astroid Framework Nov 30, 2024
@Tomisslaw
Copy link
Author

Tomisslaw commented Nov 30, 2024

Huh, this maybe cause another problem. Now I got an error line in the Joomla built in contact form. It says: /home/magnaexpeditions/public_html/libraries/src/Form/FormField.php
on line
602

Here is the screenshot if it help. The link is https://magna-expeditions.com/hr/kontakt

image

@Tomisslaw
Copy link
Author

Huh, this maybe cause another problem. Now I got an error line in the Joomla built in contact form. It says: /home/magnaexpeditions/public_html/libraries/src/Form/FormField.php on line 602

Here is the screenshot if it help. The link is https://magna-expeditions.com/hr/kontakt

image

I am not sure any more if this is related to the Bub/Fix. I reverted back to the original state, but the error stil stays.

@Tomisslaw
Copy link
Author

I hope this is my last message on this topic. The initial bug is solved by you. The second thing ist a bug by Joomla itself. When a Contact is linked to an user, and this and that contact is displayed on the site, the error ocur.

@Tomisslaw Tomisslaw reopened this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants