Rename INDEXED_VALUE_TYPE_STRING to INDEXED_VALUE_TYPE_TEXT #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Oct 16, 2021
| - WIRE |
There was a problem hiding this comment.
Had to lower compatibility level for build to pass. Enum name is not used anywhere in the user or SDK code.
There was a problem hiding this comment.
They are used by sdk-php and sdk-core:
https://sourcegraph.com/search?q=context:temporalio+INDEXED_VALUE_TYPE_STRING&patternType=literal
There was a problem hiding this comment.
Looks like pure autogenerated stuff. No actual usage I think
yiminc
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Rename
INDEXED_VALUE_TYPE_STRINGtoINDEXED_VALUE_TYPE_TEXT.Why?
To better reflect underlying Elasticsearch type.
How did you test it?
Existing server tests.
Potential risks
No risks.