Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for using the default build id set #273

Merged
merged 2 commits into from
Apr 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions temporal/api/command/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ message ScheduleActivityTaskCommandAttributes {
// Request to start the activity directly bypassing matching service and worker polling
// The slot for executing the activity should be reserved when setting this field to true.
bool request_eager_execution = 12;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the scheduled activity will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 13;
}

message RequestCancelActivityTaskCommandAttributes {
Expand Down Expand Up @@ -191,6 +197,12 @@ message ContinueAsNewWorkflowExecutionCommandAttributes {
temporal.api.common.v1.Header header = 12;
temporal.api.common.v1.Memo memo = 13;
temporal.api.common.v1.SearchAttributes search_attributes = 14;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the continued workflow will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 15;

// `workflow_execution_timeout` is omitted as it shouldn't be overridden from within a workflow.
}
Expand Down Expand Up @@ -218,6 +230,12 @@ message StartChildWorkflowExecutionCommandAttributes {
temporal.api.common.v1.Header header = 14;
temporal.api.common.v1.Memo memo = 15;
temporal.api.common.v1.SearchAttributes search_attributes = 16;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the child workflow will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 17;
}

message ProtocolMessageCommandAttributes {
Expand Down
18 changes: 18 additions & 0 deletions temporal/api/history/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ message WorkflowExecutionContinuedAsNewEventAttributes {
temporal.api.common.v1.Header header = 12;
temporal.api.common.v1.Memo memo = 13;
temporal.api.common.v1.SearchAttributes search_attributes = 14;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the scheduled activity will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 15;

// workflow_execution_timeout is omitted as it shouldn't be overridden from within a workflow.
}
Expand Down Expand Up @@ -270,6 +276,12 @@ message ActivityTaskScheduledEventAttributes {
// configuration. Retries will happen up to `schedule_to_close_timeout`. To disable retries set
// retry_policy.maximum_attempts to 1.
temporal.api.common.v1.RetryPolicy retry_policy = 12;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the scheduled activity will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 13;
}

message ActivityTaskStartedEventAttributes {
Expand Down Expand Up @@ -556,6 +568,12 @@ message StartChildWorkflowExecutionInitiatedEventAttributes {
temporal.api.common.v1.Header header = 15;
temporal.api.common.v1.Memo memo = 16;
temporal.api.common.v1.SearchAttributes search_attributes = 17;
// If this is set and the workflow executing this command is on a task queue using build-id
// versioning, then the child workflow will not use the same compatible version set (which
// is the default behavior) and instead will use the current overall default for the queue.
// If this command's `task_queue` field differs from the executing workflow's task queue, then
// this flag has no effect.
bool use_latest_build_id = 19;
}

message StartChildWorkflowExecutionFailedEventAttributes {
Expand Down