Add normal_task_queue_name to TaskQueue #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
May 24, 2023
| @@ -45,6 +45,9 @@ message TaskQueue { | |||
| string name = 1; | |||
| // Default: TASK_QUEUE_KIND_NORMAL. | |||
| temporal.api.enums.v1.TaskQueueKind kind = 2; | |||
| // Iff kind == TASK_QUEUE_KIND_STICKY, then this field contains the name of | |||
There was a problem hiding this comment.
Suggested change
| // Iff kind == TASK_QUEUE_KIND_STICKY, then this field contains the name of | |
| // If kind == TASK_QUEUE_KIND_STICKY, then this field contains the name of |
There was a problem hiding this comment.
Pretty sure he means if and only if
There was a problem hiding this comment.
Yeah, that shortcut language is a bit rough here. I would have just dismissed this and assumed we always set this string since it is the normal name after all.
Sushisource
approved these changes
May 24, 2023
Co-authored-by: Chad Retz <chad.retz@gmail.com>
Sushisource
added a commit
that referenced
this pull request
May 25, 2023
Co-authored-by: Chad Retz <chad.retz@gmail.com> --------- Co-authored-by: Spencer Judge <sjudge@hey.com> Co-authored-by: Chad Retz <chad.retz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Include normal task queue name with sticky queues.
Why?
For versioning, we want sticky queues to subscribe to versioning data for their associated normal queues, so that we can properly stop dispatching tasks to out-of-date workers that are still polling. There are various ways to get this information into matching, but the best is to ensure it's always present in the TaskQueue message.
Breaking changes
There are some subtle compatibility concerns around using this field in the server, but in general it won't break anything that already works because by definition, sticky queues are ephemeral, only sticky queues get this new field, and workers using versioning need to be using new versions of the SDK anyway.