Disable slice flag separator to accept JSON input #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Nov 11, 2022
feedmeapples
force-pushed
the
disable-slice-flag-separator
branch
from
4bd2e00 to
5233ceb
Compare
feedmeapples
force-pushed
the
disable-slice-flag-separator
branch
from
5233ceb to
0182124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Disables separating slice flags by comma
,Requires urfave/cli#1582
Why?
We had to stay on urfave/cli v2.4.0 because newer versions were forcing
,separator on slice flags. The change allows to upgrade to the latest urfave & disable the separatorChecklist
Closes
How was this tested:
Updated unit test
TestAcceptStringSliceArgsWithCommas