Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish only non-RC releases #594

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Publish only non-RC releases #594

merged 1 commit into from
Jun 12, 2024

Conversation

antlai-temporal
Copy link
Contributor

What was changed

Change GitHub action for publishing releases so it only updates docker images with releases that are NOT release candidates.

Why?

Avoid publishing OSS server docker images with RC cli dependencies.

@antlai-temporal antlai-temporal requested a review from cretz June 12, 2024 19:11
cretz
cretz approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may have to revisit if we ever do a release of of another branch besides main.

@antlai-temporal antlai-temporal merged commit f5013ad into main Jun 12, 2024
7 checks passed
@antlai-temporal antlai-temporal deleted the publish-ignore-rc branch June 12, 2024 19:28
@antlai-temporal antlai-temporal mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antlai-temporal @cretz