-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global context-rpc-timeout
option
#676
Conversation
This needs to be a general context timeout for the whole system IMO (left unset defaults to per-call of 10s). This is not specific to Note the timeout being set in this PR is a context one that spans many RPC calls. We may be able to call it RPC timeout if we want, but we need to explain that it's not necessarily per RPC, and IMO it should be a top-level option. |
hmm, is |
The problem is that "context" is a Go thing and people using the CLI don't care what language it is written in. I think we can probably have a "rpc timeout" though and document that it spans all RPCs on the CLI. Would be open to any other naming too that represents Go context timeout for life of the command without expecting people to even know we're using Go (but a bit afraid of generic "timeout" because it's only for things using the context). Maybe "client timeout"? |
Workflow show
context-rpc-timeout
option
Can you explain what this means? Or does this no longer apply now that I moved this to be a global option, and it applies to all RPC calls for the CLI? |
What was changed
Added a new global RPC timeout for within a context.
Why?
A slow remote codec can cause timeouts
Checklist
Closes [Feature Request] Heavy remote codecs need longer timeouts #648
How was this tested: