Create new string-enum[] type
#677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Sep 23, 2024
dnr
reviewed
Sep 23, 2024
josh-berry
approved these changes
Sep 24, 2024
dnr
reviewed
Sep 24, 2024
Comment on lines
+58
to
+61
| values := make([]string, 0, len(s.Allowed)) | ||
| for _, v := range s.Allowed { | ||
| values = append(values, v) | ||
| } |
There was a problem hiding this comment.
just a suggestion if you like
Suggested change
| values := make([]string, 0, len(s.Allowed)) | |
| for _, v := range s.Allowed { | |
| values = append(values, v) | |
| } | |
| values := maps.Values(s.Allowed) |
(from "golang.org/x/exp/maps")
There was a problem hiding this comment.
from "golang.org/x/exp/maps"
I think it's in the standard library now w/ the iter stuff (so not a slice necessarily)
There was a problem hiding this comment.
They didn't include Keys and Values from x/exp/maps in the stdlib package. I'm not sure why, they're pretty useful 🤷
Co-authored-by: David Reiss <dnr@dnr.im>
yuandrew
added a commit
to yuandrew/cli
that referenced
this pull request
Oct 2, 2024
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> <!-- Describe what has changed in this PR --> Created a new `string-enum[]` type <!-- Tell your future self why have you made these changes --> Command option behavior already exists, there just wasn't a specific type for this yet. <!--- add/delete as needed ---> 1. Closes temporalio#670 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io --> --------- Co-authored-by: David Reiss <dnr@dnr.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Created a new
string-enum[]typeWhy?
Command option behavior already exists, there just wasn't a specific type for this yet.
Checklist
Closes [Feature Request] Create new 'string-enum[]' type for the CLI command generation #670
How was this tested: