EDU-709 - Gcp features for AFTER REPLAY #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaf
reviewed
Sep 12, 2024
MasonEgger
changed the title
jumbogo
reviewed
Dec 6, 2024
jumbogo
reviewed
Dec 6, 2024
jumbogo
reviewed
Dec 6, 2024
jumbogo
reviewed
Jan 6, 2025
jumbogo
reviewed
Jan 6, 2025
jumbogo
reviewed
Jan 6, 2025
jumbogo
reviewed
Jan 6, 2025
jumbogo
reviewed
Jan 6, 2025
|
@MasonEgger my comment above is still unaddressed |
axfelix
reviewed
Jan 14, 2025
| ## Working with exported files | ||
|
|
||
| The proto schema is defined in https://github.com/temporalio/api/blob/master/temporal/api/export/v1/message.proto. You could build your own custom deserializer for it. | ||
| You can find sample go code to reference when you want to deserialize export file in the Appendix section of this document. |
axfelix
reviewed
Jan 14, 2025
| @@ -65,6 +63,7 @@ The following steps guide you through setting up Workflow History Export using t | |||
| 3. After inputting the necessary values, click on **Verify**. | |||
| You should be able to write to the sink successfully. | |||
| If not, please fix any errors or reach out to support for help. | |||
| * If you just created the GCS bucket and granted the permission for your service account, it may take some time for it to populate the permission, thus, you may need to wait for several minutes (usually 1-5 minutes) then you can click the “Verify” button to verify the connection. | |||
There was a problem hiding this comment.
"several minutes (usually 1-5 minutes)" is a bit gnarly, can we just say "up to 5 minutes"
There was a problem hiding this comment.
Also, not sure those should be smart quotes around Verify.
There was a problem hiding this comment.
We bold UI, so i changed it.
axfelix
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in the various GCP docs features. These were already reviewed by @xaf. Currently the links from the individual pages are not included, these will be added after first round of GCP docs are released to ensure easier rebasing. Also, sidebar.js will need to be updated.