EDU-3747: Add Temporal Auth Scopes for web ui docker env vars #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing Docker env var that's require to authenticate using IDP.
|
|
fairlydurable
changed the title
fairlydurable
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the missing docker environment variable that's required to authenticate using an IDP, ie google as per the docs.
Fixes #3268
Notes to reviewers
I had issues when using Zitadel IDP due to missing scopes. When looking into the ui-server I noticed https://github.com/temporalio/ui-server/blob/8abe1b660af4bdbe73b6fd1ecdb740c4ead29272/docker/README.md?plain=1#L22 the env, adding this resolved my issue regarding missing scopes.