Automate selection of latest SDK versions #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 28, 2024
cretz
reviewed
Aug 29, 2024
yuandrew
changed the title
|
Should be ready for review! |
cretz
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
One minor non-blocking suggestion, but LGTM. Would like @Sushisource to look to since he's more familiar with these workflows.
cretz
approved these changes
Aug 30, 2024
Sushisource
approved these changes
Aug 30, 2024
Comment on lines
+57
to
+58
| go_latest="${{ github.event.inputs.go_sdk_version }}" | ||
| if [ -z "$go_latest" ]; then |
There was a problem hiding this comment.
This script is long enough that I'm tempted to say it ought to go in a file, but, I can see how that's really annoying with the amount of variable interpolation going on. So, up to you if you think that's worth it.
I really wish GH's syntax highlighter at least did a better job here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add a new
latest-sdk-versioncommand to query GH API to get the latest release version. Automatically run CI against latest SDK releases.Also added a mechanism to run the CI manually, specifying a custom SDK version to allow testing of versions that aren't the latest
This currently bumps the following SDK versions:
typescript: 1.10.3 -> 1.11.1
java: 1.25.0 -> 1.25.1
typescript: 1.2.0 -> 1.3.0
Why?
Prevent losing test coverage for accidentally forgetting to bump a version manually
Checklist
Closes
How was this tested:
Not sure how to test the override mechanism without having this merged into main. Because the newly added
dispatch_workflowtrigger isn't in main, I'm unable to trigger CI manually.