Make Java async accepted test more forgiving #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
fix-java-async-accepted
branch
from
42535cd to
2c13f55
Compare
Quinn-With-Two-Ns
changed the title
Quinn-With-Two-Ns
force-pushed
the
fix-java-async-accepted
branch
from
2c13f55 to
dd90883
Compare
alexshtin
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexshtin Noticed the Java SDKs
startUpdateAPI behaved differently then other SDK APIs wherestartUpdatewith a wait stage of accepted may throw an exception even if the update is accepted (currently if it does or not just depends on a race in the server AFAIK). I consider this a bug in the Java SDK implementation, and should be fixed. For now making the test slightly more permissive to avoid blocking any server work.