Added liveliness probe to the web deployment. #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: didn't add startup or readiness since the other components don't have these either. temporalio#591
|
|
robholland
requested changes
Jan 16, 2025
- periodSeconds: 10 - successThreshold: 1 - timeoutSeconds: 1 - failureThreshold: 3 Verified the probe is still running with those values after they've been removed. temporalio#625
|
@robholland thanks for the feedback - the default settings are cleaned up and tested. failureThreshold was the only additional setting that could be removed. |
robholland
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Modified the web-deployment.yml to specify a liveliness probe on the web component monitoring the http port.
Note: didn't add startup or readiness since the other components don't have these either.
Why?
Improved monitoring of the web component.
Checklist
Closes [Feature Request] Web Deployment has no probes #591
(only if you don't care about the readiness and startup probes)
How was this tested:
Used 'kubectl describe' on the web container to verify changes.
Decreased initialDelaySeconds with a bad tcpSocket port to verify error condition.
Fixed the port to verify there's a Liveliness section in the description and no errors.
Any docs updates needed?
No