-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update-with-Start #114
Conversation
7cfa58c
to
0764a65
Compare
0764a65
to
6e0eb1d
Compare
go.temporal.io/api v1.36.0 | ||
go.temporal.io/sdk v1.28.1 | ||
go.temporal.io/api v1.38.0 | ||
go.temporal.io/sdk v1.29.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Go SDK is required.
6e0eb1d
to
24a5469
Compare
24a5469
to
dd60fc2
Compare
var handle client.WorkflowUpdateHandle | ||
if upd.WithStart { | ||
op := client.NewUpdateWithStartWorkflowOperation(opts) | ||
startOpts := e.StartOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making a copy to avoid changing the shared options (since they are re-used).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm! Thanks so much for taking the time to add these here.
What was changed
Added support for Update-with-Start to fuzzer.
Why?
Get coverage for Update-with-Start.
Checklist
Closes
How was this tested: