Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update-with-Start #114

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Sep 3, 2024

What was changed

Added support for Update-with-Start to fuzzer.

Why?

Get coverage for Update-with-Start.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@stephanos stephanos force-pushed the update-with-start branch 4 times, most recently from 7cfa58c to 0764a65 Compare September 3, 2024 18:05
@stephanos stephanos changed the title Update-with-Start Add Update-with-Start Sep 6, 2024
go.temporal.io/api v1.36.0
go.temporal.io/sdk v1.28.1
go.temporal.io/api v1.38.0
go.temporal.io/sdk v1.29.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Go SDK is required.

@stephanos stephanos marked this pull request as ready for review September 6, 2024 18:06
var handle client.WorkflowUpdateHandle
if upd.WithStart {
op := client.NewUpdateWithStartWorkflowOperation(opts)
startOpts := e.StartOptions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a copy to avoid changing the shared options (since they are re-used).

Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! Thanks so much for taking the time to add these here.

@stephanos stephanos merged commit 0489251 into temporalio:main Sep 9, 2024
9 checks passed
@stephanos stephanos deleted the update-with-start branch September 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants