Use deterministic version of asyncio.wait #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Sep 24, 2024
dandavison
commented
Sep 24, 2024
| @@ -98,7 +98,7 @@ async def run_action(action: Action) -> None: | |||
| should_return_task = asyncio.create_task( | |||
| workflow.wait_condition(lambda: return_value is not None) | |||
| ) | |||
| done, _ = await asyncio.wait( | |||
| done, _ = await workflow.wait( | |||
| [gather_fut, should_return_task], return_when=asyncio.FIRST_COMPLETED | |||
| ) # type: ignore | |||
| for fut in done: | |||
There was a problem hiding this comment.
Annoyingly, mypy doesn't infer that done is awaitable here. Not sure why that's not causing lint errors in the SDK (e.g. tests).
There was a problem hiding this comment.
kitchen_sink.py:105: error: Incompatible types in "await" (actual type "object", expected type "Awaitable[Any]")
There was a problem hiding this comment.
Investigated a bit. The problem is the heterogenous arguments (an asyncio.Future and an asyncio.Task). mypy cannot handle this, whether for asyncio.wait or for our version of wait, but the wrong inference it makes is slightly different between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://python.temporal.io/temporalio.workflow.html#wait