Add build-id option to Go worker. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows testing of build-id versioning using omes.
7 tasks
robholland
commented
Oct 16, 2024
| @@ -61,6 +61,8 @@ func runWorkers(client client.Client, taskQueues []string, options cmdoptions.Wo | |||
| taskQueue := taskQueue | |||
| go func() { | |||
| w := worker.New(client, taskQueue, worker.Options{ | |||
| BuildID: options.BuildID, | |||
| UseBuildIDForVersioning: options.BuildID != "", | |||
There was a problem hiding this comment.
This feels safe, but maybe this needs to be an explicit option?
|
cc @Prajithp |
cretz
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added an option to pass a build ID to the worker.
Why?
This allows testing of build-id versioning using omes.
Checklist
Closes
How was this tested: