Disable UI in functional test #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test less reliable due to a bug in how the SDK calculated the port number to use (Go SDK Issue #1526)
robholland
approved these changes
Jun 21, 2024
|
It was a happy accident, since it led us to find a bug in the SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I disabled the UI when starting the DevServer in the functional test.
Why?
When running the functional test through a GitHub action on Windows, I observed that the test failed due to an invalid (out of range) port number calculated for the UI server. That's a bug in the SDK (and I filed a report on it), but Chad states that enabling the UI should not be necessary in this test. Consequently, I have disabled it, which should ensure that the test runs reliably while the SDK bug remains.
I tested this by running the functional test manually multiple times after making the change. It passed each time (although I probably need to run it 65,535 times to feel really confident).