- more strict php tests

temporalio · Jan 22, 2021 · aa5f424 · aa5f424
1 parent 2fc67c4
commit aa5f424
Show file tree

Hide file tree

Showing 41 changed files with 371 additions and 47 deletions.
diff --git a/test/src/Workflow/ActivityStubWorkflow.php b/test/src/Workflow/ActivityStubWorkflow.php
@@ -7,6 +7,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class ActivityStubWorkflow
 {
     #[WorkflowMethod(name: 'ActivityStubWorkflow')]
@@ -35,4 +36,4 @@ public function handler(
 
         return $result;
     }
-}
+}
diff --git a/test/src/Workflow/AggregatedWorkflow.php b/test/src/Workflow/AggregatedWorkflow.php
@@ -0,0 +1,30 @@
+<?php
+
+namespace Temporal\Tests\Workflow;
+
+use Temporal\Workflow;
+use Temporal\Workflow\SignalMethod;
+use Temporal\Workflow\WorkflowInterface;
+use Temporal\Workflow\WorkflowMethod;
+
+#[WorkflowInterface]
+class AggregatedWorkflow
+{
+    private array $values = [];
+
+    #[SignalMethod]
+    public function addValue(
+        string $value
+    ) {
+        $this->values[] = $value;
+    }
+
+    #[WorkflowMethod(name: 'AggregatedWorkflow')]
+    public function run(
+        int $count
+    ) {
+        yield Workflow::await(fn() => count($this->values) === $count);
+
+        return $this->values;
+    }
+}
diff --git a/test/src/Workflow/AsyncActivityWorkflow.php b/test/src/Workflow/AsyncActivityWorkflow.php
@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Temporal\Tests\Workflow;
+
+use Temporal\Activity\ActivityCancellationType;
+use Temporal\Activity\ActivityOptions;
+use Temporal\Workflow;
+use Temporal\Workflow\WorkflowMethod;
+use Temporal\Tests\Activity\SimpleActivity;
+
+#[Workflow\WorkflowInterface]
+class AsyncActivityWorkflow
+{
+    #[WorkflowMethod(name: 'AsyncActivityWorkflow')]
+    public function handler()
+    {
+        $simple = Workflow::newActivityStub(
+            SimpleActivity::class,
+            ActivityOptions::new()
+                ->withStartToCloseTimeout(20)
+                ->withCancellationType(ActivityCancellationType::WAIT_CANCELLATION_COMPLETED)
+        );
+
+        return yield $simple->external();
+    }
+}
diff --git a/test/src/Workflow/BinaryWorkflow.php b/test/src/Workflow/BinaryWorkflow.php
@@ -7,6 +7,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class BinaryWorkflow
 {
     #[WorkflowMethod(name: 'BinaryWorkflow')]
@@ -17,4 +18,4 @@ public function handler(
 
         return yield Workflow::executeActivity('SimpleActivity.md5', [$input], $opts);
     }
-}
+}
diff --git a/test/src/Workflow/CancelSignalledChildWorkflow.php b/test/src/Workflow/CancelSignalledChildWorkflow.php
@@ -3,10 +3,10 @@
 namespace Temporal\Tests\Workflow;
 
 use React\Promise\Deferred;
-use Temporal\Exception\CancellationException;
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class CancelSignalledChildWorkflow
 {
     private array $status = [];
@@ -54,4 +54,4 @@ function () use ($simple, $waitSignalled) {
             return 'cancelled ok';
         }
     }
-}
+}
diff --git a/test/src/Workflow/CanceledHeartbeatWorkflow.php b/test/src/Workflow/CanceledHeartbeatWorkflow.php
@@ -4,21 +4,24 @@
 
 namespace Temporal\Tests\Workflow;
 
+use Temporal\Activity\ActivityCancellationType;
 use Temporal\Activity\ActivityOptions;
-use Temporal\Common\RetryOptions;
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 use Temporal\Tests\Activity\HeartBeatActivity;
 
+#[Workflow\WorkflowInterface]
 class CanceledHeartbeatWorkflow
 {
     #[WorkflowMethod(name: 'CanceledHeartbeatWorkflow')]
-    public function handler(
-        int $iterations
-    ): iterable {
+    public function handler(): iterable
+    {
         $act = Workflow::newActivityStub(
             HeartBeatActivity::class,
-            ActivityOptions::new()->withStartToCloseTimeout(50)
+            ActivityOptions::new()
+                ->withStartToCloseTimeout(50)
+                ->withCancellationType(ActivityCancellationType::WAIT_CANCELLATION_COMPLETED)
+                ->withHeartbeatTimeout(1)
         );
 
         return yield $act->slow('test');

diff --git a/test/src/Workflow/CancelledMidflightWorkflow.php b/test/src/Workflow/CancelledMidflightWorkflow.php
@@ -3,11 +3,11 @@
 namespace Temporal\Tests\Workflow;
 
 use Temporal\Activity\ActivityOptions;
-use Temporal\Exception\CancellationException;
 use Temporal\Tests\Activity\SimpleActivity;
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class CancelledMidflightWorkflow
 {
     private array $status = [];
@@ -44,4 +44,4 @@ function () {
 
         return 'OK';
     }
-}
+}
diff --git a/test/src/Workflow/CancelledNestedWorkflow.php b/test/src/Workflow/CancelledNestedWorkflow.php
@@ -6,6 +6,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class CancelledNestedWorkflow
 {
     private array $status = [];
@@ -68,4 +69,4 @@ function () {
 
         return 'OK';
     }
-}
+}
diff --git a/test/src/Workflow/CancelledScopeWorkflow.php b/test/src/Workflow/CancelledScopeWorkflow.php
@@ -7,6 +7,7 @@
 use Temporal\Workflow\WorkflowMethod;
 use Temporal\Tests\Activity\SimpleActivity;
 
+#[Workflow\WorkflowInterface]
 class CancelledScopeWorkflow
 {
     #[WorkflowMethod(name: 'CancelledScopeWorkflow')]
@@ -35,4 +36,4 @@ function () use (&$cancelled) {
 
         return $cancelled;
     }
-}
+}
diff --git a/test/src/Workflow/CancelledSingleScopeWorkflow.php b/test/src/Workflow/CancelledSingleScopeWorkflow.php
@@ -8,6 +8,7 @@
 use Temporal\Workflow\WorkflowMethod;
 use Temporal\Tests\Activity\SimpleActivity;
 
+#[Workflow\WorkflowInterface]
 class CancelledSingleScopeWorkflow
 {
     private array $status = [];
@@ -23,7 +24,8 @@ public function handler()
     {
         $simple = Workflow::newActivityStub(
             SimpleActivity::class,
-            ActivityOptions::new()->withStartToCloseTimeout(5)
+            ActivityOptions::new()
+                ->withStartToCloseTimeout(5)
         );
 
         $this->status[] = 'start';
@@ -50,4 +52,4 @@ function () {
 
         return 'OK';
     }
-}
+}
diff --git a/test/src/Workflow/CancelledWithCompensationWorkflow.php b/test/src/Workflow/CancelledWithCompensationWorkflow.php
@@ -8,6 +8,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class CancelledWithCompensationWorkflow
 {
     private array $status = [];
@@ -75,4 +76,4 @@ function () use ($simple) {
         $this->status[] = 'result: ' . $result;
         return $result;
     }
-}
+}
diff --git a/test/src/Workflow/CancelledWorkflow.php b/test/src/Workflow/CancelledWorkflow.php
@@ -8,6 +8,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class CancelledWorkflow
 {
     #[WorkflowMethod(name: 'CancelledWorkflow')]
@@ -27,4 +28,4 @@ public function handler()
             return "CANCELLED";
         }
     }
-}
+}
diff --git a/test/src/Workflow/ChainedWorkflow.php b/test/src/Workflow/ChainedWorkflow.php
@@ -8,6 +8,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class ChainedWorkflow
 {
     #[WorkflowMethod(name: 'ChainedWorkflow')]

diff --git a/test/src/Workflow/ChildStubWorkflow.php b/test/src/Workflow/ChildStubWorkflow.php
@@ -5,6 +5,7 @@
 use Temporal\Workflow;
 use Temporal\Workflow\WorkflowMethod;
 
+#[Workflow\WorkflowInterface]
 class ChildStubWorkflow
 {
     #[WorkflowMethod(name: 'ChildStubWorkflow')]
@@ -26,4 +27,4 @@ public function handler(
 
         return $result;
     }
-}
+}
diff --git a/test/src/Workflow/ComplexExceptionalWorkflow.php b/test/src/Workflow/ComplexExceptionalWorkflow.php
@@ -0,0 +1,26 @@
+<?php
+
+namespace Temporal\Tests\Workflow;
+
+use Temporal\Activity\ActivityOptions;
+use Temporal\Common\RetryOptions;
+use Temporal\Tests\Activity\SimpleActivity;
+use Temporal\Workflow;
+use Temporal\Workflow\WorkflowMethod;
+
+#[Workflow\WorkflowInterface]
+class ComplexExceptionalWorkflow
+{
+    #[WorkflowMethod(name: 'ComplexExceptionalWorkflow')]
+    public function handler()
+    {
+        $child = Workflow::newChildWorkflowStub(
+            ExceptionalActivityWorkflow::class,
+            Workflow\ChildWorkflowOptions::new()->withRetryOptions(
+                (new RetryOptions())->withMaximumAttempts(1)
+            )
+        );
+
+        return yield $child->handler();
+    }
+}
diff --git a/test/src/Workflow/ContinuableWorkflow.php b/test/src/Workflow/ContinuableWorkflow.php
@@ -8,6 +8,7 @@
 use Temporal\Workflow\WorkflowMethod;
 use Temporal\Tests\Activity\SimpleActivity;
 
+#[Workflow\WorkflowInterface]
 class ContinuableWorkflow
 {
     #[WorkflowMethod(name: 'ContinuableWorkflow')]
@@ -32,6 +33,6 @@ public function handler(
             yield $simple->echo((string)$generation);
         }
 
-        return Workflow::newContinueAsNewStub(self::class)->handler(++$generation);
+        return Workflow::continueAsNew('ContinuableWorkflow', [++$generation]);
     }
-}
+}
diff --git a/test/src/Workflow/EmptyWorkflow.php b/test/src/Workflow/EmptyWorkflow.php
@@ -3,12 +3,14 @@
 namespace Temporal\Tests\Workflow;
 
 use Temporal\Workflow\WorkflowMethod;
+use Temporal\Workflow;
 
+#[Workflow\WorkflowInterface]
 class EmptyWorkflow
 {
-    #[WorkflowMethod(name: 'EmptyWorkflow')]
+    #[WorkflowMethod]
     public function handler()
     {
         return 42;
     }
-}
+}
diff --git a/test/src/Workflow/ExceptionalActivityWorkflow.php b/test/src/Workflow/ExceptionalActivityWorkflow.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace Temporal\Tests\Workflow;
+
+use Temporal\Activity\ActivityOptions;
+use Temporal\Common\RetryOptions;
+use Temporal\Tests\Activity\SimpleActivity;
+use Temporal\Workflow;
+use Temporal\Workflow\WorkflowMethod;
+
+#[Workflow\WorkflowInterface]
+class ExceptionalActivityWorkflow
+{
+    #[WorkflowMethod(name: 'ExceptionalActivityWorkflow')]
+    public function handler()
+    {
+        $simple = Workflow::newActivityStub(
+            SimpleActivity::class,
+            ActivityOptions::new()->withStartToCloseTimeout(5)
+                ->withRetryOptions((new RetryOptions())->withMaximumAttempts(1))
+        );
+
+        return yield $simple->fail();
+    }
+}
diff --git a/test/src/Workflow/ExceptionalWorkflow.php b/test/src/Workflow/ExceptionalWorkflow.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Temporal\Tests\Workflow;
+
+use Temporal\Activity\ActivityOptions;
+use Temporal\Tests\Activity\SimpleActivity;
+use Temporal\Workflow;
+use Temporal\Workflow\WorkflowMethod;
+
+#[Workflow\WorkflowInterface]
+class ExceptionalWorkflow
+{
+    #[WorkflowMethod(name: 'ExceptionalWorkflow')]
+    public function handler()
+    {
+        throw new \RuntimeException("workflow error");
+    }
+}
diff --git a/test/src/Workflow/FailedHeartbeatWorkflow.php b/test/src/Workflow/FailedHeartbeatWorkflow.php
@@ -10,6 +10,7 @@
 use Temporal\Workflow\WorkflowMethod;
 use Temporal\Tests\Activity\HeartBeatActivity;
 
+#[Workflow\WorkflowInterface]
 class FailedHeartbeatWorkflow
 {
     #[WorkflowMethod(name: 'FailedHeartbeatWorkflow')]