Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): move tests to the rr-e2e-tests repo #186

Merged
merged 4 commits into from
Feb 19, 2022

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

  • Single place for the RR end-to-end tests

Description of Changes

  • Move integrational tests to the rr-e2e-tests repository

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added A-tests Area: test (update, create, etc...) C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Feb 19, 2022
@rustatian rustatian requested a review from wolfy-j February 19, 2022 19:07
@rustatian rustatian self-assigned this Feb 19, 2022
@rustatian rustatian added this to the v1.3.x milestone Feb 19, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #186 (d6ae2e8) into master (685b681) will decrease coverage by 62.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #186       +/-   ##
==========================================
- Coverage   66.46%   3.79%   -62.68%     
==========================================
  Files          14      14               
  Lines         844     844               
==========================================
- Hits          561      32      -529     
- Misses        218     810      +592     
+ Partials       65       2       -63     
Impacted Files Coverage Δ
data_converter/converter.go 36.84% <ø> (ø)
plugin.go 0.00% <ø> (-68.26%) ⬇️
workflow/handler.go 0.00% <0.00%> (-76.58%) ⬇️
internal/logger/wrapper.go 0.00% <0.00%> (-75.00%) ⬇️
activity/activity.go 0.00% <0.00%> (-72.73%) ⬇️
workflow/workflow.go 0.00% <0.00%> (-72.39%) ⬇️
rpc.go 0.00% <0.00%> (-72.00%) ⬇️
metrics.go 0.00% <0.00%> (-66.67%) ⬇️
workflow/registry/registry.go 0.00% <0.00%> (-64.29%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685b681...d6ae2e8. Read the comment docs.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@wolfy-j
Copy link
Collaborator

wolfy-j commented Feb 19, 2022

Is it possible to relink codecov?

Copy link
Collaborator

@wolfy-j wolfy-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally to keep codecov bagde.

@rustatian rustatian merged commit bdb18b5 into master Feb 19, 2022
@rustatian rustatian deleted the tests/move-tests-to-the-rr-e2e-test branch February 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: test (update, create, etc...) C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants