Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(activities): local activities #203

Merged
merged 6 commits into from
Apr 13, 2022
Merged

feat(activities): local activities #203

merged 6 commits into from
Apr 13, 2022

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

Description of Changes

  • Local activities support.
  • Single temporal worker for the activities and workflows.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Mar 31, 2022
@rustatian rustatian requested a review from wolfy-j March 31, 2022 20:57
@rustatian rustatian self-assigned this Mar 31, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #203 (78c80bd) into master (824132e) will decrease coverage by 0.38%.
The diff coverage is 2.32%.

@@            Coverage Diff            @@
##           master    #203      +/-   ##
=========================================
- Coverage    4.46%   4.08%   -0.39%     
=========================================
  Files          14      15       +1     
  Lines        1164    1200      +36     
=========================================
- Hits           52      49       -3     
- Misses       1110    1149      +39     
  Partials        2       2              
Impacted Files Coverage Δ
aggregatedpool/activity.go 0.00% <0.00%> (ø)
aggregatedpool/canceller/canceller.go 100.00% <ø> (ø)
aggregatedpool/handler.go 0.00% <0.00%> (ø)
aggregatedpool/init.go 0.00% <0.00%> (ø)
aggregatedpool/registry/registry.go 0.00% <ø> (ø)
aggregatedpool/workflow.go 0.00% <0.00%> (ø)
internal/codec/proto/proto.go 0.00% <0.00%> (ø)
internal/protocol.go 0.00% <0.00%> (ø)
plugin.go 0.00% <0.00%> (ø)
rpc.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824132e...78c80bd. Read the comment docs.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
rrversion passed to the worker

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian changed the title feat(activities): local activities [WIP] feat(activities): local activities Apr 13, 2022
@rustatian rustatian marked this pull request as ready for review April 13, 2022 16:25
@rustatian rustatian merged commit cb1497d into master Apr 13, 2022
@rustatian rustatian deleted the feat/local_activities branch April 13, 2022 16:29
@rustatian rustatian added this to the v1.4.x milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Support LocalActivities
3 participants