Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mTLS support #274

Merged
merged 2 commits into from
Sep 27, 2022
Merged

feat: mTLS support #274

merged 2 commits into from
Sep 27, 2022

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Sep 26, 2022

Reason for This PR

closes: roadrunner-server/roadrunner#1300

Description of Changes

  • Add mTLS support.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added B-missing feature Bug: missing feature after implementation C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Sep 26, 2022
@rustatian rustatian added this to the v1.6.x milestone Sep 26, 2022
@rustatian rustatian requested a review from wolfy-j September 26, 2022 14:15
@rustatian rustatian self-assigned this Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #274 (1855ff9) into master (4892aae) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #274      +/-   ##
=========================================
- Coverage    3.24%   3.12%   -0.13%     
=========================================
  Files          15      15              
  Lines        1480    1538      +58     
=========================================
  Hits           48      48              
- Misses       1430    1488      +58     
  Partials        2       2              
Impacted Files Coverage Δ
config.go 0.00% <0.00%> (ø)
plugin.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rustatian rustatian merged commit a2abfdf into master Sep 27, 2022
@rustatian rustatian deleted the feat/mTLS branch September 27, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-missing feature Bug: missing feature after implementation C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Add mTLS support for the temporal plugin
3 participants