-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upsert search attributes #275
Conversation
Hey @cv65kr 👋🏻 |
aab4c14
to
a0ce155
Compare
@rustatian Updated, also signed my commits. And big sorry for removing template 😄 I will back to you as soon as I test whole implementation together with SDK-PHP. |
@rustatian fixed and tested. I did small mistake and encoder was not needed. |
@cv65kr Could you please add a PHP worker to the description (which sends this command)? I'll add it to our international tests: https://github.com/roadrunner-server/rr-e2e-tests. |
@rustatian You meant workflow definition? I see general worker https://github.com/roadrunner-server/rr-e2e-tests/blob/master/php_test_files/temporal-worker.php Also added info about definition of search attributes which need to be executed before running such test. |
@rustatian to make your live easier I prepared changes in E2E repository - roadrunner-server/rr-e2e-tests#138 Feel free to modify it since I put my branches there, because we need to wait for merge. |
Great, thank you, @cv65kr 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reason for This PR
temporalio/sdk-php#76
Same functionality like in GO-SDK - https://github.com/temporalio/samples-go/tree/main/searchattributes
Changes needed in PHP-SDK - temporalio/sdk-php#248
Description of Changes
Added missing implementation of
UpsertWorkflowSearchAttributes
command.E2E
Changes: roadrunner-server/rr-e2e-tests#138
Workflow file: https://github.com/temporalio/sdk-php/blob/6a40e81ba7125ee32fbb242599f65ddff649500a/tests/Fixtures/src/Workflow/UpsertSearchAttributesWorkflow.php
Also definition of search attributes needs to be executed to test server before running workflow - https://github.com/temporalio/sdk-php/blob/6a40e81ba7125ee32fbb242599f65ddff649500a/tests/SearchAttributeTestInvoker.php
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.