Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass headers to the PHP worker #303

Merged
merged 6 commits into from
Dec 11, 2022
Merged

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

  • PHP Headers skipped in the internal message structure.

Description of Changes

  • Add header field to the internal message structure.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Dec 6, 2022
@rustatian rustatian added this to the v2.x milestone Dec 6, 2022
@rustatian rustatian requested a review from wolfy-j December 6, 2022 12:30
@rustatian rustatian self-assigned this Dec 6, 2022
@rustatian rustatian changed the title chore: pass headers to the PHP chore: pass headers to the PHP worker Dec 6, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Merging #303 (567e247) into master (942c8b2) will increase coverage by 0.12%.
The diff coverage is 2.02%.

@@            Coverage Diff            @@
##           master    #303      +/-   ##
=========================================
+ Coverage    3.04%   3.17%   +0.12%     
=========================================
  Files          15      18       +3     
  Lines        1575    1605      +30     
=========================================
+ Hits           48      51       +3     
- Misses       1525    1552      +27     
  Partials        2       2              
Impacted Files Coverage Δ
aggregatedpool/activity.go 0.00% <0.00%> (ø)
aggregatedpool/handler.go 0.00% <0.00%> (ø)
aggregatedpool/interceptor.go 0.00% <0.00%> (ø)
aggregatedpool/workers.go 0.00% <0.00%> (ø)
aggregatedpool/workflow.go 0.00% <0.00%> (ø)
common/context.go 0.00% <0.00%> (ø)
info.go 0.00% <0.00%> (ø)
internal/codec/proto/proto.go 0.00% <0.00%> (ø)
internal/protocol.go 0.00% <0.00%> (ø)
metrics.go 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit b06b5cc into master Dec 11, 2022
@rustatian rustatian deleted the feature/pass-headers-to-php branch December 11, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants