-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Enable client certificate rotation by using tls.Config@GetClientCertificate #523
feature: Enable client certificate rotation by using tls.Config@GetClientCertificate #523
Conversation
Lukas Benke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…ientCertificate instead of building and passing the key pair statically
1ede8da
to
fee8e51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
===========================================
+ Coverage 22.67% 36.49% +13.81%
===========================================
Files 4 13 +9
Lines 269 959 +690
===========================================
+ Hits 61 350 +289
- Misses 206 539 +333
- Partials 2 70 +68 ☔ View full report in Codecov by Sentry. |
Thanks, @benkelukas 👍 LGTM, will be released next week with RR v2024.1.3. |
Thanks @rustatian - that's great news! 🎉 |
Enable client certificate rotation by providing a callback to tls.Config@GetClientCertificate when setting up Temporal connection
Reason for This PR
Closes: #522
Description of Changes
Added a callback for GetClientCertificate to enable client certificate rotation when mTLS connection fails, e.g. after it changes in the referenced cert and key files
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.