Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: deprecate JSON context #538

Merged
merged 2 commits into from
Jul 24, 2024
Merged

feature: deprecate JSON context #538

merged 2 commits into from
Jul 24, 2024

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Jul 12, 2024 •
edited
Loading

Reason for This PR

  • Deprecate JSON context in internal RR<->PHP communications.

Description of Changes

  • Move JSON context fields to the proto.Message.
  • Add new field: HistorySize

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian
feature: deprecate JSON context
f36db87 
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 12, 2024
@rustatian rustatian requested a review from wolfy-j July 12, 2024 19:19
@rustatian rustatian self-assigned this Jul 12, 2024
@rustatian rustatian marked this pull request as ready for review July 24, 2024 13:09
@rustatian rustatian merged commit 188b76a into master Jul 24, 2024
10 checks passed
@rustatian rustatian deleted the feature/rr-2024.2-proto branch July 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy-j wolfy-j wolfy-j approved these changes

Assignees

@rustatian rustatian

Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustatian @wolfy-j