Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply correct shutdown order #554

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

closes: roadrunner-server/roadrunner#1986

Description of Changes

  • Apply the following shutdown order:
  1. Stop the T-workers to stop receiving any tasks.
  2. Stop PHP workers (WF+ACT).
  3. Close the tally metrics.
  4. Close the temporal server connection.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the B-bug Bug: bug, unhandled exception label Sep 5, 2024
@rustatian rustatian requested a review from wolfy-j September 5, 2024 14:36
@rustatian rustatian self-assigned this Sep 5, 2024
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 27cc2eb into master Sep 10, 2024
10 checks passed
@rustatian rustatian deleted the fix/incorrectly-closed-grpc branch September 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, unhandled exception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: grpc client is closed to early after graceful shutdown
2 participants