Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JSON schema, adjust documentation and defaults #570

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

nickdnk
Copy link
Contributor

@nickdnk nickdnk commented Oct 25, 2024

Adjust error messages
Add documented defaults for FlushBytes

Reason for This PR

Following my work in the roadrunner org where I've been moving all JSON schemas to the repos they belong to, here is that same change for temporal.

Description of Changes

Added JSON schema.
Adjusted some error messages (syntax, grammar) and added default values according to documentation.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Adjust error messages
Add documented defaults for FlushBytes
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nickdnk

@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Oct 25, 2024
@rustatian rustatian merged commit 9b7a55e into temporalio:master Oct 25, 2024
7 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.06%. Comparing base (c8e0bcf) to head (c5a93ee).
Report is 299 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #570       +/-   ##
===========================================
+ Coverage   22.67%   40.06%   +17.38%     
===========================================
  Files           4       14       +10     
  Lines         269      936      +667     
===========================================
+ Hits           61      375      +314     
- Misses        206      518      +312     
- Partials        2       43       +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants