-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(h2c): optional certificates for TLS #579
base: master
Are you sure you want to change the base?
Conversation
Hey @cv65kr 👋 |
I guess it is better to introduce an option in the TLS config, like, |
@rustatian changed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
=======================================
Coverage 40.06% 40.06%
=======================================
Files 14 14
Lines 936 936
=======================================
Hits 375 375
Misses 518 518
Partials 43 43 ☔ View full report in Codecov by Sentry. |
Reason for This PR
In case of h2c there a no need to provide certificates with enabled TLS option
Description of Changes
If TLS is enabled certificates files are optional.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.