-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable activity workers #592
Conversation
Changes need to be provided to https://github.com/roadrunner-server/pool/blob/master/pool/config.go#L42 |
We can't change the default behavior for the pool. In the pool ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 40.06% 36.71% -3.36%
==========================================
Files 14 14
Lines 936 1095 +159
==========================================
+ Hits 375 402 +27
- Misses 518 652 +134
+ Partials 43 41 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @cv65kr 👍🏻
Reason for This PR
roadrunner-server/roadrunner#2089
Description of Changes
Disable activity workers
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.