Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a saga pattern sample #204

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Add a saga pattern sample #204

merged 1 commit into from
Jun 27, 2022

Conversation

pavlo-v-chernykh
Copy link
Contributor

What was changed

Add a saga pattern sample.

Why?

There is no saga pattern sample.

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022

CLA assistant check
All committers have signed the CLA.

@cretz
Copy link
Member

cretz commented Jun 10, 2022

For most use cases, saga seems to "just properly use defer" in Go. We even had a saga impl suggested as part of the SDK at temporalio/sdk-go#744 and we are still trying to decide how best to support saga pattern across SDKs at temporalio/features#50. I will confirm with others the value of this sample (I saw it was a TODO in the README) and get back.

We (kinda) document how to do a cleanup activity at https://pkg.go.dev/go.temporal.io/sdk/workflow#NewDisconnectedContext.

@pavlo-v-chernykh
Copy link
Contributor Author

@cretz hi. Did you have a chance to talk with the team?

@cretz
Copy link
Member

cretz commented Jun 23, 2022

We can accept this, Can you sign the CLA?

@pavlo-v-chernykh
Copy link
Contributor Author

@cretz, I'm glad to know.
I've signed the CLA.
Please, proceed.

@pavlo-v-chernykh
Copy link
Contributor Author

@cretz, it looks like I do not have write access to this repository to merge the pull request. Please, merge it.

@cretz cretz merged commit 014be0f into temporalio:main Jun 27, 2022
@pavlo-v-chernykh pavlo-v-chernykh deleted the saga-pattern-sample branch June 27, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants