Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Avoid Node v22.12.0 on Windows #402

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mjameswh
Copy link
Contributor

What was changed

  • In CI, avoids Node v22.12.0 on Windows, because it incorrectly resolves localhost to ::1, rather than both ::1 and 127.0.0.1, which is causing errors when executing tests. We can remove this workaround once a fix version of Node is released.

Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjameswh mjameswh merged commit c87e4a6 into temporalio:main Dec 18, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants