Updates for update reapply #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
update-reapply
branch
from
0f7b349 to
b7f0cd6
Compare
dandavison
commented
Feb 16, 2024
| if event.event_type() == EventType::Unspecified | ||
| || event.event_type() == EventType::WorkflowExecutionUpdateRequested | ||
| || event.attributes.is_none() | ||
| { |
There was a problem hiding this comment.
There are two manual changes to sdk-core in this PR. This is one of them. All other changes were made by updating the protos subtree.
dandavison
commented
Feb 16, 2024
| @@ -1981,6 +1981,7 @@ pub mod temporal { | |||
| Attributes::WorkflowExecutionUpdateRejectedEventAttributes(_) => {EventType::WorkflowExecutionUpdateRejected} | |||
| Attributes::WorkflowExecutionUpdateAcceptedEventAttributes(_) => {EventType::WorkflowExecutionUpdateAccepted} | |||
| Attributes::WorkflowExecutionUpdateCompletedEventAttributes(_) => {EventType::WorkflowExecutionUpdateCompleted} | |||
| Attributes::WorkflowExecutionUpdateRequestedEventAttributes(_) => {EventType::WorkflowExecutionUpdateRequested} | |||
There was a problem hiding this comment.
This is the second of the two manual changes.
Sushisource
approved these changes
Feb 16, 2024
rsync -auv ../api/temporal/ sdk-core-protos/protos/api_upstream/temporal/
dandavison
force-pushed
the
update-reapply
branch
from
b7f0cd6 to
b539787
Compare
Yes that's right. https://github.com/temporalio/temporal/blob/1645bea925812026397f0a5f4594e2978154b457/service/history/historybuilder/event_factory.go#L412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sdk-core to work with the new
EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_REQUESTEDevent added in temporalio/api#351How this was tested
I have built
sdk-pythonagainst this branch and have an in-progress server branch that demonstrates correct processing of the new update event bysdk-python: temporalio/temporal#5361