Client refactoring #870
Merged
Client refactoring #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
client-refactor
branch
2 times, most recently
from
5493e62 to
e8e5f92
Compare
Sushisource
force-pushed
the
client-refactor
branch
from
e8e5f92 to
8a0fbf0
Compare
cretz
approved these changes
Feb 3, 2025
Some publicly visible types changed, but not ones that lang would be using (more like Rust SDK client), and they changed in ways that should be backwards compat or very simple to deal with (import another trait) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Some client cleanup I needed to do while working on poller scaling
Why?
Paying down some debt & better organization
Checklist
Closes
How was this tested:
Existing tests
Any docs updates needed?