Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] DI worker service not using obtained logger factory #116

Closed
cretz opened this issue Jul 25, 2023 · 0 comments · Fixed by #119
Closed

[Bug] DI worker service not using obtained logger factory #116

cretz opened this issue Jul 25, 2023 · 0 comments · Fixed by #119
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jul 25, 2023

Describe the bug

We are checking whether existing client's logger factory is null which is impossible. Either make that possible or remove the check.
@cretz cretz added the bug Something isn't working label Jul 25, 2023
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Jul 25, 2023
@cretz
Use DI logger factory in worker service
0c8ca9f 
Fixes temporalio#116
@cretz cretz mentioned this issue Jul 25, 2023
Merged
cretz added a commit that referenced this issue Jul 25, 2023
@cretz
Use DI logger factory in worker service and DI clients (#119)
612d4ca 
Fixes #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use DI logger factory in worker service and DI clients cretz/temporal-sdk-dotnet
1 participant
@cretz