Better .NET Framework support and smoke test #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
framework-smoke-test
branch
7 times, most recently
from
4e9b8c3 to
80106f2
Compare
Sushisource
approved these changes
Jul 12, 2023
|
Like other .NET issues currently, I am not merging until I can make a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add targets file to properly include shared library in output and add .NET Framework smoke test to confirm NuGet package works with .NET framework. This was tested with the "Build Package" GH action during development (though it's only invoked after push to
mainnot in PR).Checklist