Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning enum updates, rename "Cancelled" identifiers to "Canceled" (💥 BREAKING CHANGE), and README updates #112

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Jul 18, 2023

What was changed

  • Changed to use existing API enum for TaskReachability
  • Changed VersioningIntent to be an enum
  • Changed identifiers (but not text necessarily) from Cancelled to Canceled - 💥 BREAKING CHANGE
  • Added a section in the README clarifying workflow inheritance
  • Added a section in the README clarifying some details about the native shared library

Checklist

  1. Closes Use single-L for all cancelled (sic) type names like .NET does #109
  2. Closes [Feature Request] Clarify inheritance rules/reasons for workflow attributes #106
  3. Closes [Feature Request] Clarify in README the role of the native shared library #107

@cretz cretz requested a review from a team July 18, 2023 18:40
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so it looks like the exhaustive matches still work, which is all I cared about. When I did this before I was forced to add a blanket _ => xxx case to the switches which is why I didn't want to use enums.

@cretz cretz merged commit 0dc06cd into temporalio:main Jul 18, 2023
@cretz cretz deleted the more-refactors-2 branch July 18, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants