Support for experimental workflow task events #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jul 19, 2023
| @@ -36,6 +36,44 @@ public TemporalWorkerOptions() | |||
| /// <param name="taskQueue">Task queue for the worker.</param> | |||
| public TemporalWorkerOptions(string taskQueue) => TaskQueue = taskQueue; | |||
|
|
|||
| /// <summary> | |||
| /// Event for when a workflow task is starting. This should only be used for very advanced | |||
There was a problem hiding this comment.
Since it's experimental and we can change it, maybe call it ActivationStarting?
There was a problem hiding this comment.
The goal is task tracking even if the implementation isn't there yet. But I think the experimental API should reflect the goal instead of the current reality. I would have waited on this PR altogether but wanted to let users see the goal early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added experimental
WorkflowTaskStartingandWorkflowTaskCompletedevents toTemporalWorkerOptionsandWorkflowReplayerOptions. These are marked as experimental today and until temporalio/sdk-core#579 is created, this is only working on activations so is knowingly inaccurate.This has been requested by others wanting to do metering based on task. If this use case becomes prevalent enough we will make a features repo entry for it and will build it elsewhere and remove the experimental label.