Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log and drop signals when we can't decode the arguments #114

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Log and drop signals when we can't decode the arguments #114

merged 1 commit into from
Jul 20, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Jul 19, 2023 •
edited
Loading

What was changed

Log and drop signals whose arguments can't be decoded

Checklist

  1. Closes [Bug] Signals that can't be deserialized should be dropped/ignored #105

@cretz cretz requested a review from a team July 19, 2023 20:49
@cretz cretz merged commit 1c14789 into temporalio:main Jul 20, 2023
@cretz cretz deleted the bad-signal-deserialize branch July 20, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Signals that can't be deserialized should be dropped/ignored
2 participants
@cretz @Sushisource