Handle new .NET 8 analyzer suggestions #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am moving this to draft while I debug some CI issues |
cretz
force-pushed
the
ci-check-fixes
branch
3 times, most recently
from
7d72f6a to
56a1428
Compare
cretz
force-pushed
the
ci-check-fixes
branch
2 times, most recently
from
d830c56 to
a237308
Compare
cretz
commented
Dec 4, 2023
| run: | | ||
| dotnet tool install --global ClangSharpPInvokeGenerator | ||
| dotnet tool install --global --version 16.0.0 ClangSharpPInvokeGenerator |
There was a problem hiding this comment.
They broke ClangSharpPInvokeGenerator last week
| @@ -3,7 +3,6 @@ | |||
| <AnalysisLevel>latest</AnalysisLevel> | |||
| <AnalysisMode>AllEnabledByDefault</AnalysisMode> | |||
| <Authors>Temporal</Authors> | |||
| <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild> | |||
There was a problem hiding this comment.
.NET 8 release (or MSBuild release) seems to now be properly setting deterministic source paths when this is set, which means it strips runtime paths which hurts us because we test with them.
Quinn-With-Two-Ns
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
.NET 8 has new analyzer suggestions that are failing builds