Support macOS ARM alongside macOS Intel and upgrade Protobuf library #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
macos-arm
branch
5 times, most recently
from
b4eda55 to
74d5f6a
Compare
cretz
changed the title
cretz
force-pushed
the
macos-arm
branch
2 times, most recently
from
b93b529 to
d6de786
Compare
mjameswh
reviewed
Apr 26, 2024
| with: | ||
| # TODO(cretz): Upgrade when https://github.com/arduino/setup-protoc/issues/33 fixed | ||
| version: '3.x' | ||
| # TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed |
There was a problem hiding this comment.
Not very important, but I'm a bit puzzled by this TODO. Looks like the issue is about the default version of protoc that setup-protoc will install. But if you specify the version number explicitly, there should be no problem, no?
There was a problem hiding this comment.
Looks like this is about the default version of protoc that setup-protoc will install.
We want to pin our protoc version (different versions can generate different code). This is just saying we can't upgrade past 23.x because of that issue (though may be indirectly because of it, but I tried "27.x" here and it failed)
Quinn-With-Two-Ns
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
protocexpectation and regenerate protobufs with the newerprotocBranch protection will be updated upon approval
Checklist