Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue enumerating services in newer .NET DI library #241

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix issue enumerating services in newer .NET DI library #241

merged 1 commit into from
May 8, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented May 8, 2024

What was changed

  • Swallow exception unrelated to us when enumerating services to check for dupe worker
  • Update DI test to cause the exception (which also means updating DI library in tests)

Checklist

  1. Closes [Bug] System.InvalidOperationException: This service descriptor is keyed. Your service provider may not support keyed services #238

@cretz cretz requested a review from a team May 8, 2024 14:50
@ElanHasson ElanHasson mentioned this pull request May 8, 2024
Closed
@cretz cretz merged commit f40e78e into temporalio:main May 8, 2024
7 checks passed
@cretz cretz deleted the service-enumerate-fix branch May 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@ElanHasson ElanHasson ElanHasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cretz @ElanHasson @Quinn-With-Two-Ns