Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download cURL in older Linux containers on binary build #275

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Jun 17, 2024

What was changed

Newer GH actions fail on older Linux containers due to older cURL so we update with a statically linked one (tested while this PR was in draft)

@cretz cretz force-pushed the build-binary-fix branch 2 times, most recently from 20b00f8 to 288d030 Compare June 17, 2024 21:42
@cretz cretz force-pushed the build-binary-fix branch from 288d030 to 72980ea Compare June 17, 2024 22:00
@cretz cretz requested a review from a team June 17, 2024 22:00
@cretz cretz marked this pull request as ready for review June 17, 2024 22:00
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cretz cretz merged commit c0058a1 into temporalio:main Jun 18, 2024
7 checks passed
@cretz cretz deleted the build-binary-fix branch June 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants