Add workflow update RPC timeout/canceled exception #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jun 21, 2024
| rpcErr.Code == RpcException.StatusCode.DeadlineExceeded || | ||
| rpcErr.Code == RpcException.StatusCode.Cancelled))) | ||
| { | ||
| throw new WorkflowUpdateRpcTimeoutOrCanceledException(e); |
There was a problem hiding this comment.
Do we not want to keep retrying the start in these cases? Or, I guess right now that doesn't matter since there's no explicit overall "update timeout", only the rpc timeout?
There was a problem hiding this comment.
No, these are usually caused by user-provided timeout or user-initiated cancel. Right, there is no update timeout yet which would be an application level concern and would be considered an update failure as opposed to an RPC failure.
Sushisource
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
WorkflowUpdateRpcTimeoutOrCanceledExceptionand ensured that it was thrown on update RPC calls that are cancelled or timeoutChecklist