Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule identifier to warning and edit signal warning message #317

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Temporalio/Worker/WorkflowInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2264,13 +2264,13 @@ private class Handlers : LinkedList<Handlers.Handler>
LoggerMessage.Define<string, WarnableSignals>(
LogLevel.Warning,
0,
"Workflow {Id} finished while signal handlers are still running. This may " +
"[TMPRL1102] Workflow {Id} finished while signal handlers are still running. This may " +
"have interrupted work that the signal handler was doing. You can wait for " +
"all update and signal handlers to complete by using `await " +
"Workflow.WaitConditionAsync(() => Workflow.AllHandlersFinished)`. " +
"Alternatively, if both you and the clients sending the signal are okay with " +
"interrupting running handlers when the workflow finishes, and causing " +
"clients to receive errors, then you can disable this warning via the signal " +
"interrupting running handlers when the workflow finishes, " +
"then you can disable this warning via the signal " +
"handler attribute: " +
"`[WorkflowSignal(UnfinishedPolicy=HandlerUnfinishedPolicy.Abandon)]`. The " +
"following signals were unfinished (and warnings were not disabled for their " +
Expand All @@ -2280,7 +2280,7 @@ private class Handlers : LinkedList<Handlers.Handler>
LoggerMessage.Define<string, WarnableUpdates>(
LogLevel.Warning,
0,
"Workflow {Id} finished while update handlers are still running. This may " +
"[TMPRL1102] Workflow {Id} finished while update handlers are still running. This may " +
"have interrupted work that the update handler was doing, and the client " +
"that sent the update will receive a 'workflow execution already completed' " +
"RpcException instead of the update result. You can wait for all update and " +
Expand Down