Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency and add .NET 8 in one CI #356

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Upgrade dependency and add .NET 8 in one CI #356

merged 3 commits into from
Oct 31, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 8, 2024 •
edited
Loading

What was changed

  • Update System.Text.Json minimum version to account for vuln at GHSA-hh2w-p6rv-4g7w
    • Note, we do not always blindly upgrade transitive dependencies on our users for every vuln, but this is a semver patch-level upgrade which is a no brainer
  • Use .NET 8 during compile on one of the matrix targets to ensure we catch this in the future
    • Only recently have .NET warnings been added for dependencies with vulns

Checklist

  1. Closes NU1903 error when run dotnet build  #347

@cretz cretz mentioned this pull request Oct 8, 2024
Closed
@cretz cretz changed the title Use .NET 8 in CI Upgrade dependency and add .NET 8 in one CI Oct 25, 2024
@cretz cretz requested a review from a team October 25, 2024 15:42
@cretz cretz marked this pull request as ready for review October 25, 2024 15:42
@cretz cretz merged commit 6a858a2 into temporalio:main Oct 31, 2024
8 checks passed
@cretz cretz deleted the dotnet-8-in-ci branch October 31, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NU1903 error when run dotnet build
2 participants
@cretz @Sushisource